Skip to content

Provide more clear example for WRONG_SELF_CONVENTION #13325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

alex-semenyuk
Copy link
Member

Provide more clear example for WRONG_SELF_CONVENTION

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 31, 2024
@alex-semenyuk alex-semenyuk changed the title Provide more clear example forWRONG_SELF_CONVENTION Provide more clear example for WRONG_SELF_CONVENTION Aug 31, 2024
@alex-semenyuk alex-semenyuk force-pushed the wrong_self_convention_doc_fix branch from 3bfe233 to 989ebae Compare August 31, 2024 18:06
@alex-semenyuk alex-semenyuk requested a review from y21 August 31, 2024 18:17
@y21
Copy link
Member

y21 commented Sep 1, 2024

Looks good, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Sep 1, 2024

📌 Commit 989ebae has been approved by y21

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 1, 2024

⌛ Testing commit 989ebae with merge a81f1c8...

@bors
Copy link
Contributor

bors commented Sep 1, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: y21
Pushing a81f1c8 to master...

@bors bors merged commit a81f1c8 into rust-lang:master Sep 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants