Skip to content

(Small) Fix broken links for Rust merge #10604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

(Small) Fix broken links for Rust merge #10604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/src/development/adding_lints.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ because that's clearly a non-descriptive name.
- [Lint passes](#lint-passes)
- [Emitting a lint](#emitting-a-lint)
- [Adding the lint logic](#adding-the-lint-logic)
- [Specifying the lint's minimum supported Rust version (MSRV)](#specifying-the-lints-minimum-supported-rust-version--msrv-)
- [Specifying the lint's minimum supported Rust version (MSRV)](#specifying-the-lints-minimum-supported-rust-version-msrv)
- [Author lint](#author-lint)
- [Print HIR lint](#print-hir-lint)
- [Documentation](#documentation)
Expand Down
2 changes: 1 addition & 1 deletion book/src/usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,4 @@ clippy-driver --edition 2018 -Cpanic=abort foo.rs
> that are not optimized as expected, for example.

[Installation]: installation.md
[CI]: continuous_integration/index.md
[CI]: continuous_integration/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this change caused a new issue: rust-lang/rust#110003 (comment)

Copy link
Member Author

@blyxyas blyxyas Apr 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea how to fix it then.
index.html didn't work (even though it's the URL from the book leading to that section), and README.md also doesn't work, even though it appears like that on SUMMARY.md. What more could it be?

Even then, all link's were checked with the mdbook-linkcheck crate before committing them. Could this be a bug in CI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also out of ideas what could cause this. I'll make sure that we're using the same mdbook version in Clippy as in the Rust repo. Maybe some version difference broke something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10630

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I had the same issue before, when I finalized the first version of the book. Links to README.mds inside the book are a bit weird...