Skip to content

fix: not suggest seek_to_start_instead_of_rewind when expr is used #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2022
Merged

fix: not suggest seek_to_start_instead_of_rewind when expr is used #10096

merged 1 commit into from
Dec 17, 2022

Conversation

feniljain
Copy link
Contributor

@feniljain feniljain commented Dec 17, 2022 •
edited by xFrednet
Loading

changelog: [seek_to_start_instead_of_rewind]: No longer lints, if the return of seek is used.
#10096

Fixes #10065

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 17, 2022
@xFrednet
Copy link
Member

Hey @feniljain, welcome to Clippy. TIL that we have is_expr_used_or_unified as a function, that is cool. The implementation looks good to me. Thank you for the contribution, I hope you had fun!

@bors r+

@bors
Copy link
Contributor

bors commented Dec 17, 2022

📌 Commit c39849a has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 17, 2022

⌛ Testing commit c39849a with merge 391b2a6...

@bors
Copy link
Contributor

bors commented Dec 17, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 391b2a6 to master...

@bors bors merged commit 391b2a6 into rust-lang:master Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xFrednet xFrednet xFrednet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seek_to_start_instead_of_rewind fires when rewind cannot replace seek
5 participants
@feniljain @rustbot @xFrednet @bors @flip1995