hir-ty: add incremental tests checking for infer invalidation
#19914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
force-pushed
the
davidbarsky/add-some-additional-incrementalism-tests
branch
from
8df7701 to
98f32c1
Compare
|
Updated the tests to assert which queries were run. |
Veykril
approved these changes
Jun 4, 2025
davidbarsky
deleted the
davidbarsky/add-some-additional-incrementalism-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tests that check that
inferis invalidated when a DefMap is invalidated. These new tests will need to fixed and renamed #19837 by:adding_use_statement_invalidates_infertoadding_use_statement_should_not_invalidate_infer.eventsassertion toassert!(!format!("{events:?}").contains("infer_shim"), "{events:#?}").(Full disclosure: I used Claude Sonnet 4 to write these tests. I am, of course, responsible for any code I submit for review, but it wasn't half bad at the job. I had to rename a few tests/example code in the tests, however.)