This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Revert test for workspace_symbol #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed in f1c85eb to account for the new DefKinds in rls-data. However, this will not pass rustc tests (i.e. `./x.py test src/tools/rls`) when updating the RLS submodule in that project. I believe this is because the versions of rls-data are different between rustc and the rls. In order for the RLS to be updated with rustc, this test should be updated to pass. Then, once that change is release to the nightly channel, the tests in this repo will pass again. I have tested this theory when running a locally built version of rustc that has the lastest commit of the RLS (5930bab) as the tip of the rls submodule. These tests pass in both the rustc and rls repositories then. Also, the previously referenced commit was incorrectly changed; `Kind` should be 2 for the result, not 5.
|
@DSpeckhals merged, sorry for the delay |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in f1c85eb to account
for the new DefKinds in rls-data. However, this will not pass rustc
tests (i.e.
./x.py test src/tools/rls) when updating the RLS submodulein that project. I believe this is because the versions of rls-data are
different between rustc and the rls. In order for the RLS to be updated
with rustc, this test should be updated to pass. Then, once that change
is release to the nightly channel, the tests in this repo will pass
again.
I have tested this theory when running a locally built version of rustc
that has the lastest commit of the RLS (5930bab)
as the tip of the rls submodule. These tests pass in both the rustc and
rls repositories then.
Also, the previously referenced commit was incorrectly changed;
Kindshould be 2 for the result, not 5.
Please see this issue in rustc for more context.