-
Notifications
You must be signed in to change notification settings - Fork 390
CI: add windows-arm runner #4479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to Miri! |
7d7e6b5
to
8835d26
Compare
This doesn't work yet, rustup-toolchain-install-master currently cannot be built on windows-arm since it depends on winapi:
Cc @kennytm |
@kennytm judging from a8m/pb#123 it seems like actually kennytm/rustup-toolchain-install-master#61 is enough to fix this... any chance you could cut a release? |
@RalfJung published 1.9.0. |
c4bfacb
to
ec6e486
Compare
Okay, that seems to work. :) But it is super slow. |
// there would be a collision with other invocations of cargo-miri (as rustdoc or as runner). We | ||
// explicitly do this even if RUSTC_STAGE is set, since for these builds we do *not* want the | ||
// bootstrap `rustc` thing in our way! Instead, we have MIRI_HOST_SYSROOT to use for host | ||
// builds. | ||
cmd.env("RUSTC", fs::canonicalize(find_miri()).unwrap()); | ||
cmd.env("RUSTC", path::absolute(find_miri()).unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some behavior difference between x86-win32 and arm-win64 somewhere which lead to things breaking if we use canonicalize
here. 🤷
Thank you for contributing to Miri! |
After disabling GC_STRESS, the runtime is reasonable. So, the runner seems to be pretty slow, but that's a problem with all Windows runners. |
No description provided.