Skip to content

CI: add windows-arm runner #4479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

CI: add windows-arm runner #4479

merged 1 commit into from
Jul 23, 2025

Conversation

RalfJung
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2025

Thank you for contributing to Miri!
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jul 19, 2025
@RalfJung RalfJung force-pushed the ci-win-arm branch 3 times, most recently from 7d7e6b5 to 8835d26 Compare July 19, 2025 08:01
@RalfJung
Copy link
Member Author

This doesn't work yet, rustup-toolchain-install-master currently cannot be built on windows-arm since it depends on winapi:

rustup-toolchain-install-master v1.8.1 (/home/r/src/rust/rustup-toolchain-install-master)
├── ansi_term v0.12.1
│   └── winapi v0.3.9
...
├── pbr v1.1.1
│   ├── crossbeam-channel v0.5.15
│   │   └── crossbeam-utils v0.8.21
│   ├── libc v0.2.174
│   └── winapi v0.3.9 (*)

Cc @kennytm
Might be relevant for rust-lang/rfcs#3817

@RalfJung RalfJung marked this pull request as draft July 19, 2025 08:05
@rustbot rustbot added S-waiting-on-author Status: Waiting for the PR author to address review comments and removed S-waiting-on-review Status: Waiting for a review to complete labels Jul 19, 2025
@RalfJung RalfJung added S-blocked Status: blocked on something happening somewhere else and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Jul 19, 2025
This was referenced Jul 19, 2025
Closed
Merged
@RalfJung
Copy link
Member Author

@kennytm judging from a8m/pb#123 it seems like actually kennytm/rustup-toolchain-install-master#61 is enough to fix this... any chance you could cut a release?

@kennytm
Copy link
Member

kennytm commented Jul 21, 2025

@RalfJung published 1.9.0.

@RalfJung RalfJung force-pushed the ci-win-arm branch 2 times, most recently from c4bfacb to ec6e486 Compare July 22, 2025 21:13
@RalfJung
Copy link
Member Author

Okay, that seems to work. :) But it is super slow.

RalfJung
RalfJung commented Jul 23, 2025
View reviewed changes
cargo-miri/src/phases.rs
// there would be a collision with other invocations of cargo-miri (as rustdoc or as runner). We
// explicitly do this even if RUSTC_STAGE is set, since for these builds we do *not* want the
// bootstrap `rustc` thing in our way! Instead, we have MIRI_HOST_SYSROOT to use for host
// builds.
cmd.env("RUSTC", fs::canonicalize(find_miri()).unwrap());
cmd.env("RUSTC", path::absolute(find_miri()).unwrap());
Copy link
Member Author

@RalfJung RalfJung Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some behavior difference between x86-win32 and arm-win64 somewhere which lead to things breaking if we use canonicalize here. 🤷

@RalfJung RalfJung marked this pull request as ready for review July 23, 2025 08:16
@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2025

Thank you for contributing to Miri!
Please remember to not force-push to the PR branch except when you need to rebase due to a conflict or when the reviewer asks you for it.

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jul 23, 2025
@RalfJung
Copy link
Member Author

After disabling GC_STRESS, the runtime is reasonable. So, the runner seems to be pretty slow, but that's a problem with all Windows runners.

@RalfJung RalfJung added this pull request to the merge queue Jul 23, 2025
Merged via the queue into rust-lang:master with commit ae56827 Jul 23, 2025
14 checks passed
@RalfJung RalfJung deleted the ci-win-arm branch July 23, 2025 08:44
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-blocked Status: blocked on something happening somewhere else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RalfJung @rustbot @kennytm