-
Notifications
You must be signed in to change notification settings - Fork 388
Adjust Miri to also require return places everywhere #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rust-lang/rust#96098 just landed; could you rebase and update the rust-version file? Then this is good to go. :) |
✌️ @JakobDegen can now approve this pull request |
@bors r+ |
📌 Commit 4bbb7d9 has been approved by |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@bors r+ |
📌 Commit e428d29 has been approved by |
☀️ Test successful - checks-actions |
Ah, apologies, was asleep. Thanks for handling this! |
This is the miri side of rust-lang/rust#96098 . It'll still need a bump to rust-version once the rust PR is merged, but the test suite passes against my local build of rustc.