refactor drop glue and fix Box<Box<Struct>> as Box<Trait> #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solson
reviewed
Feb 9, 2017
src/memory.rs
Outdated
| /// Drop glue takes the `self` by value, while `Drop::drop` take `&mut self` | ||
| DropGlue(FunctionDefinition<'tcx>), | ||
| /// A drop glue function only needs to know the real type, and then miri can extract the | ||
| /// actual type at runtime. |
There was a problem hiding this comment.
Can you clarify "real type" vs "actual type"?
erickt
pushed a commit
to erickt/miri
that referenced
this pull request
Feb 4, 2022
Add more methods matching the standard HashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129
the commits are best viewed each on its own