Fails to build with msvc target

[jminer]

I tried to cargo install Racer today, but it failed because libz-sys failed to compile. I have cargo installed Racer before, but I think it was with the gnu target. I recently switched to msvc, partially because that's what ring recommends. I'm using

rustc 1.29.0-nightly (54628c8ea 2018-07-30)
i686-pc-windows-msvc
Windows 10 64-bit
Visual Studio 2017 15.7.3

When it wouldn't build with Visual Studio 2017 RC, I updated to 15.7.3 today, but no change.

I just cloned the libz-sys repository, opened a PowerShell window, and it gives the same error:

PS C:\Files\Projects\libz-sys> cargo build
   Compiling cc v1.0.18
   Compiling vcpkg v0.2.4
   Compiling pkg-config v0.3.12
   Compiling libc v0.2.42
   Compiling libz-sys v1.0.18 (file:///C:/Files/Projects/libz-sys)
error: failed to run custom build command for `libz-sys v1.0.18 (file:///C:/Files/Projects/libz-sys)`
process didn't exit successfully: `C:\Files\Projects\libz-sys\target\debug\build\libz-sys-933099ae9f1330d8\build-script-build` (exit code: 1)
--- stdout
cargo:rerun-if-env-changed=LIBZ_SYS_STATIC
cargo:rerun-if-changed=build.rs
note, vcpkg did not find zlib: Could not find Vcpkg tree: No vcpkg.user.targets found. Set the VCPKG_ROOT environment variable or run 'vcpkg integrate install'
running: "nmake.exe" "/nologo" "/f" "C:\\Files\\Projects\\libz-sys\\target\\debug\\build\\libz-sys-7b5cb260792e8afa\\out\\build/win32/Makefile.msc" "zlib.lib"


failed to execute command: The system cannot find the file specified. (os error 2)
Is `nmake.exe` not installed?

Since ring successfully builds, and it also uses the MSVC toolchain, it seems libz-sys should be working too. Looks like VS isn't being detected properly? I tried running nmake from a VS command prompt and that works. (I haven't tried running Cargo from a VS command prompt yet.)

[alexcrichton]

This crate currently relies on the cc crate to find nmake.exe which has a lot of logic for finding things, although I'm not sure the best way to debug your setup to figure out how that can be tweaked to find nmake.exe :(

[jminer]

I spent a few minutes investigating where the problem is. I tried calling find_tool("i686-pc-windows-msvc", "nmake.exe") and of course it returns None. Looking into the code, vs15_vc_paths is returning bin_path =

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.14.26428\bin\HostX64\x86

But there's no nmake.exe in that folder. It has cl.exe, lib.exe, and link.exe, but no nmake.exe, so tool_from_vs15_instance will return None. The folders with nmake in them:

Hostx64\x64   yes
Hostx64\x86   no
Hostx86\x64   no
Hostx86\x86   yes

Besides nmake.exe, there are other tools missing from those two folders, including cvtres.exe, pgocvt.exe, pgomgr.exe, pgosweep.exe, undname.exe, and xdcmake.exe.

Looks like the x64_x86 command prompt that VS installs falls back to Hostx64\x64 for missing tools and the x86_x64 command prompt falls back to Hostx86\x86.

[Folyd]

Same error on x86_64-pc-windows-gnu. Here is the log and appveyor build history link.

Running `C:\projects\anyshortcut-cli\target\debug\build\libz-sys-1f10d8e74680426c\build-script-build`
error: failed to run custom build command for `libz-sys v1.0.18`
process didn't exit successfully: `C:\projects\anyshortcut-cli\target\debug\build\libz-sys-1f10d8e74680426c\build-script-build` (exit code: 1)
--- stdout
OPT_LEVEL = Some("0")
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
TARGET = Some("x86_64-pc-windows-gnu")
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
CC_x86_64-pc-windows-gnu = None
CC_x86_64_pc_windows_gnu = None
HOST_CC = None
CC = None
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
CFLAGS_x86_64-pc-windows-gnu = None
CFLAGS_x86_64_pc_windows_gnu = None
HOST_CFLAGS = None
CFLAGS = None
DEBUG = Some("true")
running: "make" "-f" "win32/Makefile.gcc" "install" "prefix=/C/projects/anyshortcut-cli/target/x86_64-pc-windows-gnu/debug/build/libz-sys-8afc481f4bb4583e/out" "IMPLIB=" "INCLUDE_PATH=/C/projects/anyshortcut-cli/target/x86_64-pc-windows-gnu/debug/build/libz-sys-8afc481f4bb4583e/out/include" "LIBRARY_PATH=/C/projects/anyshortcut-cli/target/x86_64-pc-windows-gnu/debug/build/libz-sys-8afc481f4bb4583e/out/lib" "BINARY_PATH=/C/projects/anyshortcut-cli/target/x86_64-pc-windows-gnu/debug/build/libz-sys-8afc481f4bb4583e/out/bin"
failed to execute command: The system cannot find the file specified. (os error 2)
Is `make` not installed?
warning: build failed, waiting for other jobs to finish...
error: build failed
Command exited with code 101

[alexcrichton]

I've retooled the build in #40, so this should be fixed now