Skip to content

chore: release libc v0.2.173 #4481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 9, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against libc-0.2. Please double check that you specified the right target!

@tgross35 tgross35 enabled auto-merge June 9, 2025 20:34
@tgross35 tgross35 added this pull request to the merge queue Jun 9, 2025
Merged via the queue into rust-lang:libc-0.2 with commit 1c5b553 Jun 9, 2025
48 of 49 checks passed
@tgross35 tgross35 deleted the release branch June 10, 2025 01:26
@tgross35
Copy link
Contributor Author

Heya @marcoieni do you have any idea what might have gone on here? I merged this PR bumping the version from 0.2.172 to 0.2.173, and the release-plz job ran successfully but didn't do a release https://github.com/rust-lang/libc/actions/runs/15544775261/job/43763769879.

The same thing happens locally and I can't figure out why. The latest version on crates.io is 0.2.172 so either I'm missing something or this should have published.

The PR here is pretty similar to the last release at #4410, which did get a release https://github.com/rust-lang/libc/actions/runs/14461036350/job/40553576959.

@marcoieni
Copy link
Member

that's weird, release-plz should definitely emit more logs. Since the same thing happens locally, can you add more logs as explained in https://release-plz.dev/docs/troubleshooting#see-debug-logs ?

If not sufficient, I would debug release-plz by adding more logs or using a debugger to understand why it quits so early without printing anything.

@tgross35
Copy link
Contributor Author

I checked with both 0.3.130 and 0.3.135 locally, the output is the same. With debug:

release-plz release --git-token ... -vv -ojson
2025-06-10T06:22:56.045719Z  INFO release_plz::args: crates/release_plz/src/args/mod.rs:162: using release-plz config file .release-plz.toml
2025-06-10T06:22:56.046152Z DEBUG new: git_cmd: crates/git_cmd/src/lib.rs:28: initializing directory "/Users/tmgross/Documents/projects/rust-libc"
2025-06-10T06:22:56.073724Z DEBUG release: release_plz_core::project: crates/release_plz_core/src/project.rs:56: manifest_dir: "/Users/tmgross/Documents/projects/rust-libc"
2025-06-10T06:22:56.084952Z DEBUG release: release_plz_core::project: crates/release_plz_core/src/project.rs:58: project_root: "/Users/tmgross/Documents/projects/rust-libc"
2025-06-10T06:22:56.085186Z DEBUG release: release_plz_core::release_order: crates/release_plz_core/src/release_order.rs:13: Release order: ["ctest", "ctest-next", "libc", "libc-test"]
2025-06-10T06:22:56.085231Z DEBUG release:new: git_cmd: crates/git_cmd/src/lib.rs:28: initializing directory "/Users/tmgross/Documents/projects/rust-libc"
2025-06-10T06:22:56.110463Z DEBUG release: reqwest::connect: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/reqwest-0.12.15/src/connect.rs:625: starting new connection: https://api.github.com/
2025-06-10T06:22:56.127367Z DEBUG release: hyper_util::client::legacy::connect::http: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/client/legacy/connect/http.rs:769: connecting to 140.82.113.5:443
2025-06-10T06:22:56.159328Z DEBUG release: hyper_util::client::legacy::connect::http: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/client/legacy/connect/http.rs:772: connected to 140.82.113.5:443
2025-06-10T06:22:56.230978Z DEBUG release: h2::client: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/client.rs:1290: binding client connection
2025-06-10T06:22:56.231018Z DEBUG release: h2::client: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/client.rs:1295: client connection bound
2025-06-10T06:22:56.231085Z DEBUG release: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384, max_header_list_size: 16384 }
2025-06-10T06:22:56.231228Z DEBUG release: hyper_util::client::legacy::pool: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/hyper-util-0.1.11/src/client/legacy/pool.rs:396: pooling idle connection for ("https", api.github.com)
2025-06-10T06:22:56.231264Z DEBUG release:Connection{peer=Client}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=WindowUpdate { stream_id: StreamId(0), size_increment: 5177345 }
2025-06-10T06:22:56.231363Z DEBUG release:Connection{peer=Client}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=Headers { stream_id: StreamId(1), flags: (0x5: END_HEADERS | END_STREAM) }
2025-06-10T06:22:56.262635Z DEBUG release:Connection{peer=Client}: h2::codec::framed_read: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_read.rs:404: received frame=Settings { flags: (0x0), max_concurrent_streams: 100, initial_window_size: 67108864, max_frame_size: 68608, enable_connect_protocol: 1 }
2025-06-10T06:22:56.262650Z DEBUG release:Connection{peer=Client}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=Settings { flags: (0x1: ACK) }
2025-06-10T06:22:56.262656Z DEBUG release:Connection{peer=Client}: h2::codec::framed_read: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_read.rs:404: received frame=Settings { flags: (0x1: ACK) }
2025-06-10T06:22:56.262661Z DEBUG release:Connection{peer=Client}: h2::proto::settings: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/settings.rs:56: received settings ACK; applying Settings { flags: (0x0), enable_push: 0, initial_window_size: 2097152, max_frame_size: 16384, max_header_list_size: 16384 }
2025-06-10T06:22:56.512713Z DEBUG release:Connection{peer=Client}: h2::codec::framed_read: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_read.rs:404: received frame=Headers { stream_id: StreamId(1), flags: (0x4: END_HEADERS) }
2025-06-10T06:22:56.512803Z DEBUG release: release_plz_core::git::forge: crates/release_plz_core/src/git/forge.rs:814: Associated PR found. Status: 200 OK
2025-06-10T06:22:56.512867Z DEBUG release:Connection{peer=Client}: h2::codec::framed_read: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_read.rs:404: received frame=Data { stream_id: StreamId(1) }
2025-06-10T06:22:56.512878Z DEBUG release:Connection{peer=Client}: h2::codec::framed_read: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_read.rs:404: received frame=Data { stream_id: StreamId(1), flags: (0x1: END_STREAM) }
2025-06-10T06:22:56.513114Z DEBUG release: release_plz_core::git::forge: crates/release_plz_core/src/git/forge.rs:839: Associated PRs for commit 1c5b5538c850e160a3847d065f4615f8e36f4d54: [4481]
2025-06-10T06:22:56.513153Z DEBUG release: release_plz_core::cargo: crates/release_plz_core/src/cargo.rs:33: cargo --version
2025-06-10T06:22:56.544248Z DEBUG release: release_plz_core::cargo: crates/release_plz_core/src/cargo.rs:44: cargo stderr:
2025-06-10T06:22:56.544258Z DEBUG release: release_plz_core::cargo: crates/release_plz_core/src/cargo.rs:45: cargo stdout: cargo 1.89.0-nightly (64a124607 2025-05-30)

2025-06-10T06:22:56.544308Z DEBUG release:Connection{peer=Client}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }
2025-06-10T06:22:56.544319Z DEBUG release:Connection{peer=Client}: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:440: Connection::poll; connection error error=GoAway(b"", NO_ERROR, Library)
{"releases":[]}

Rerunning with trace, the last few lines:

2025-06-10T06:23:54.876913Z DEBUG release:Connection{peer=Client}:poll:FramedWrite::buffer{frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:218: send frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }
2025-06-10T06:23:54.876918Z TRACE release:Connection{peer=Client}:poll:FramedWrite::buffer{frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }}: h2::frame::go_away: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/frame/go_away.rs:"releases":[]}
2m60: encoding GO_AWAY; code=NO_ERROR
2025-06-10T06:23:54.876952Z TRACE release:Connection{peer=Client}:poll:FramedWrite::buffer{frame=GoAway { error_code: NO_ERROR, last_stream_id: StreamId(0) }}: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:271: encoded go_away rem=17
2025-06-10T06:23:54.876959Z DEBUG release:Connection{peer=Client}:poll: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:440: Connection::poll; connection error error=GoAway(b"", NO_ERROR, Library)
2025-06-10T06:23:54.876963Z TRACE release:Connection{peer=Client}:poll: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:449:     -> already going away
2025-06-10T06:23:54.876967Z TRACE release:Connection{peer=Client}:poll: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:273: connection.state=Closing(NO_ERROR, Library)
2025-06-10T06:23:54.876970Z TRACE release:Connection{peer=Client}:poll: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:302: connection closing after flush
2025-06-10T06:23:54.877124Z TRACE release:Connection{peer=Client}:poll:FramedWrite::flush: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:145: queued_data_frame=false
2025-06-10T06:23:54.877182Z TRACE release:Connection{peer=Client}:poll:FramedWrite::flush: h2::codec::framed_write: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/codec/framed_write.rs:161: flushing buffer
2025-06-10T06:23:54.877194Z TRACE release:Connection{peer=Client}:poll: h2::proto::connection: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/connection.rs:273: connection.state=Closed(NO_ERROR, Library)
2025-06-10T06:23:54.877224Z TRACE h2::proto::streams::streams: /Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/h2-0.4.10/src/proto/streams/streams.rs:854: Streams::recv_eof
{"releases":[]}

Nothing stands out to me here, what a weird error. My GH token doesn't have permissions to publish but I don't think that would be an issue.

I'll try to debug this a bit better tomorrow or try with a build from source. I was just pretty confused 😆

@tgross35
Copy link
Contributor Author

As mentioned at release-plz/release-plz#2270 (comment) I did a bad cherry pick, fixing this at #4486 🎉.

@marcoieni
Copy link
Member

I'm glad you find the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants