Skip to content

linux_like: Add CLONE_PIDFD flag #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2021
Merged

linux_like: Add CLONE_PIDFD flag #2474

merged 2 commits into from
Oct 23, 2021

Conversation

neocturne
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Seems Emscripten doesn't have it, does it?

@neocturne
Copy link
Contributor Author

Hmm indeed. Does this mean that the definition needs to be moved to the linux / android submodules?

@JohnTitor
Copy link
Member

Hmm indeed. Does this mean that the definition needs to be moved to the linux / android submodules?

Yes 👍

JohnTitor
JohnTitor approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2021

📌 Commit 7ee7e14 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 23, 2021

⌛ Testing commit 7ee7e14 with merge 0ee0249...

bors added a commit that referenced this pull request Oct 23, 2021
@bors
Auto merge of #2474 - NeoRaider:pidfd, r=JohnTitor
0ee0249 
linux_like: Add CLONE_PIDFD flag
@bors
Copy link
Contributor

bors commented Oct 23, 2021

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Hmm, CLONE_PIDFD is available regardless of arch, right? If so, kernel header or something else on CI is old and we could skip a test for that target for now.

@neocturne
libc-test: include linux/sched.h test_linux()
e2638e3 
The UAPI version of sched.h contains the newest flags that may not have
been added to the libc's sched.h yet (for example CLONE_PIDFD). It was
alreaded included by test_android(), but was missing from test_linux().
@neocturne
Copy link
Contributor Author

I have added another commit to include linux/sched.h in test_linux(), this should do the trick.

@JohnTitor
Copy link
Member

Neat, @bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2021

📌 Commit e2638e3 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 23, 2021

⌛ Testing commit e2638e3 with merge a269368...

@bors
Copy link
Contributor

bors commented Oct 23, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing a269368 to master...

@bors bors merged commit a269368 into rust-lang:master Oct 23, 2021
@neocturne neocturne deleted the pidfd branch October 23, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neocturne @rust-highfive @JohnTitor @bors