Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

no longer can assign specific users #380

Closed
@ehuss

Description

@ehuss

In rust-lang/cargo#10313 (comment), Alex attempted to do r? @joshtriplett, but it assigned ehuss.

Looking at

highfive/highfive/newpr.py

Lines 250 to 262 in b54f081

if msg is not None:
match = reviewer_re.search(msg)
if match:
groups = self.get_groups()
potential = groups.get(match.group(2)) or groups.get("%s/%s" % (match.group(1), match.group(2))) or []
if 'all' in groups:
potential.extend(groups["all"])
picked = self.pick_reviewer(groups, potential, exclude)
if picked:
return picked
if match.group(1) is None and match.group(2):
if match.group(2).startswith('@'):
return match.group(2)[1:]
which changed in #377, it seems like it always picks from the all group, even if you specify a specific user. @Mark-Simulacrum I can't quite understand what the intent of that change. Is there a reason it always picks from all?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions