Add support for windows verbatim disk paths#112
Merged
JohnTitor merged 2 commits intorust-lang:masterfrom Jan 11, 2023
Merged
Conversation
Contributor
Author
|
Replaced matches! with an if-let. CI runs on an old rustc so it was failing and I don't know what glob's MSRV policy is. |
|
Pulled this patch locally and confirmed it addresses the issue observed in getzola/zola#1932. Happy to help out, should an extra pair of hands be needed to merge and release. |
Member
|
Seems you disabled access to this branch, could you rebase to trigger the latest CI? |
Contributor
Author
JohnTitor
approved these changes
Jan 11, 2023
Member
Hmm, that's weird, maybe I force-pushed for rebasing and that's a culprit. Anyway, this LGTM, thank you for the PR and sorry for the long delay! |
|
Just ran into the exact same issue fixed here after hunting down why a buildscript didn't behave properly on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #111