-
Notifications
You must be signed in to change notification settings - Fork 650
Implement Trusted Publishing user interface #11398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This section lists the configured Trusted Publishing configurations for this crate. Until we publicly ship this feature the section is hidden, unless the crate already has corresponding configurations configured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usual disclaimers around my lack of Ember knowledge apply, but this LGTM, and the feature gate seems like it's good. Let's get to testing this!
// assert.dom('[data-test-trusted-publishing]').exists(); | ||
// assert.dom('[data-test-no-config]').exists(); | ||
// assert.dom('[data-test-github-config]').doesNotExist(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this is already in here. 👍
This PR implements the frontend part of the Trusted Publishing feature. It adds a list of existing Trusted Publishing configurations to the crate settings page (currently only visible if they crate already has configurations to act like a feature flag...), and a new route to add such configurations to a crate.
Related: