Skip to content

Implement Trusted Publishing user interface #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2025
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 20, 2025

This PR implements the frontend part of the Trusted Publishing feature. It adds a list of existing Trusted Publishing configurations to the crate settings page (currently only visible if they crate already has configurations to act like a feature flag...), and a new route to add such configurations to a crate.

Bildschirmfoto 2025-06-20 um 14 04 16 Bildschirmfoto 2025-06-20 um 14 04 26

Related:

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Jun 20, 2025
@Turbo87 Turbo87 requested a review from a team June 20, 2025 12:18
@Turbo87 Turbo87 moved this to For next meeting in crates.io team meetings Jun 20, 2025
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual disclaimers around my lack of Ember knowledge apply, but this LGTM, and the feature gate seems like it's good. Let's get to testing this!

Comment on lines +59 to +61
// assert.dom('[data-test-trusted-publishing]').exists();
// assert.dom('[data-test-no-config]').exists();
// assert.dom('[data-test-github-config]').doesNotExist();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad this is already in here. 👍

@Turbo87 Turbo87 merged commit 0b20a04 into rust-lang:main Jun 22, 2025
11 checks passed
@Turbo87 Turbo87 deleted the trustpub-ui branch June 22, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants