Pagination is strewn around

[alexcrichton]

The actual processing code for pagination is refactored into a mixin, but the rendering code is strewn all over mostly because of the need to generate links differently in different contexts:

Examples:

• https://github.com/alexcrichton/cargo-registry/blob/master/app/templates/crates.hbs
• https://github.com/alexcrichton/cargo-registry/blob/master/app/templates/keywords.hbs
• https://github.com/alexcrichton/cargo-registry/blob/master/app/templates/search.hbs
• https://github.com/alexcrichton/cargo-registry/blob/master/app/templates/keyword/index.hbs

[wycats]

@stefanpenner @igorT can you take a look at this? What is the "correct" practice for this kind of problem?

[igorT]

Seems that all the links look the same except for the route name? They could be refactored into a component?

[alexcrichton]

Yeah currently they only differ in how they invoke link-to.

I'm a bit of an ember newb, could you elaborate a little more on what you mean by a component? I think that the pagination itself would be suited well for a component, but how would I pass in parameters for the pagination component to then pass to link-to? In some cases there's also multiple parameters where in others there's just one.

[sgrif]

We're cleaning out some of the older issues that haven't seen activity lately, so I'm going to close this.

We'd be happy to accept a PR that refactors this code. I'm going to try to open an issue in the next few days with more concrete steps as well.