Skip to content

Create constructor allowing user to set c_cfg and cxx_cfg #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lthiery
Copy link
Contributor

@lthiery lthiery commented Feb 17, 2020

In a previous PR, an extra Config field and a setter for that field were created.

Perhaps letting the user pass c_cfg and/or cxx_cfg would allow more flexible usage? Otherwise, every "useful" configuration field could potentially be made into a field and a setter.

@lthiery lthiery requested a review from alexcrichton February 17, 2020 07:19
@alexcrichton
Copy link
Member

Thanks for the PR! Could you expand a bit on the motivation for this? I'd prefer to avoid making cc part of the public API here if possible.

@lthiery
Copy link
Contributor Author

lthiery commented Feb 18, 2020

I don't feel strongly about it, but it was just an idea I had following the previous PR. Rather than adding a new Config field and a new setter for every "useful" c[xx]_cfg option, there could be a public API to initialize the c[xx]_cfg with a preconfigured c[xx]_cfg.

This just adds a huge degree of flexibility, but maybe that's not as important as obscuring cc from the public API.

@alexcrichton
Copy link
Member

Ah ok, in that case I'd prefer to keep this as-is and reexport options here as necessary, but thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants