Change --build to use an absolute path#200
Merged
tgross35 merged 1 commit intorust-lang:masterfrom Aug 19, 2024
Merged
Conversation
We do set the current directory, but it seems that some flavors of CMake
on Windows still fail with the following:
MSBUILD : error MSB1009: Project file does not exist.
Change to using an absolute path which should improve this.
ChrisDenton
added a commit
that referenced
this pull request
Dec 17, 2025
…instead (#267) Rather than canonicalising the build directory this simply makes it absolute. Unfortunately the current MSRV doesn't allow us to use `std::path::absolute` so for Windows I've added a direct call to the Windows API. Since the motivation for #200 is Windows, on non-Windows platforms this is now a no-op. Fixes cloudflare/boring#414
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do set the current directory, but it seems that some flavors of CMake on Windows still fail with the following:
Change to using an absolute path which should improve this.