-
Notifications
You must be signed in to change notification settings - Fork 509
Deprecated response files. #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this! Have you confirmed that this works on both gnu-like platforms and MSVC? I think we need to be sure to pass various flags to |
I was able to compile |
To confirm, when you say you compile for Windows, do you mean MSVC or MinGW? |
MSVC. I'll try MinGW/GCC tomorrow. Compiling for android using clang worked. |
Apparently this doesn't work just work 🤦♂️ Must have been building against the wrong local version... My bad. I couldn't find any documentation on lld or lib.exe on how to do progressive linking like this. Do you have a reference for the various flags that need to be passed? Also this solution is not 100% fool prove since in theory a single argument could exceed the command line limit. |
Sorry I'm not super familiar with |
The documentation for lib.exe seems to indicate that using |
Huh I tried that a little while ago but didn't work. Will try again. |
@maxded Solved the issue I was having! |
To simplify the code I removed response files based on the suggestion of @alexcrichton. I now call the assemble commands multiple times.
This solves #496 as well.
Currently I'm using the same logic that splits the assemble command for all hosts. Let me know if you only want to split it only for Windows.