Skip to content

Ferris: always show, even when it’s small #4280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Ferris: always show, even when it’s small #4280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9847e79
Ferris: simplify line counting for size determination
chriskrycho Mar 17, 2025
8372e56
Ferris: always show Ferrises, even if small
chriskrycho Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ferris.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,25 @@ body.ayu .not_desired_behavior {
.ferris-explain {
width: 100px;
}

/*
A bit of a hack to make small Ferris use the existing buttons container but
only show/hide the buttons on hover over the `pre`. Targeting `.listing`
increases the specificity of this rule.
*/
pre > .buttons {
visibility: visible;
opacity: 1;
transition: none;
}

pre > .buttons button {
visibility: hidden;
opacity: 0;
transition: visibility 0.1s linear, opacity 0.1s linear;
}

pre:hover > .buttons button {
visibility: visible;
opacity: 1;
}
6 changes: 4 additions & 2 deletions ferris.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,12 @@ function attachFerrises(type) {
continue;
}

let lines = codeBlock.innerText.replace(/\n$/, "").split(/\n/).length;
let codeLines = codeBlock.innerText;
let extra = codeLines.endsWith("\n") ? 1 : 0;
let numLines = codeLines.split("\n").length - extra;

/** @type {'small' | 'large'} */
let size = lines < 4 ? "small" : "large";
let size = numLines < 4 ? "small" : "large";

let container = prepareFerrisContainer(codeBlock, size == "small");
if (!container) {
Expand Down