Skip to content

Attempt to fix grammatically confusing sentence in this paragraph. #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Attempt to fix grammatically confusing sentence in this paragraph. #2936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8bd3bc
Attempt to fix grammatically confusing sentence in this paragraph.
darrow-olykos Nov 30, 2021
d19b70f
Update src/ch16-03-shared-state.md
darrow-olykos Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ch16-03-shared-state.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ that case, no one would ever be able to get the lock, so we’ve chosen to

After we’ve acquired the lock, we can treat the return value, named `num` in
this case, as a mutable reference to the data inside. The type system ensures
that we acquire a lock before using the value in `m`: `Mutex<i32>` is not an
`i32`, so we *must* acquire the lock to be able to use the `i32` value. We
that we acquire a lock before using the value in `m`: `Mutex<i32>`, because `m`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, to me, the colon after m and before Mutex<i32> means "because", so I'm not sure how adding "because" makes this clearer? What if this was two separate sentences instead, like:

The type system ensures that we acquire a lock before using the value in m. The type of m is Mutex<i32>, not i32, so we must call lock to be able to use the i32 value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carols10cents Your suggestion appears less ambiguous to me 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carols10cents I was having trouble as well when I was reading this in the book. I think it might be worth it to replace the ':' with something else (The second sentence that you wrote here seems good to me). It didn't even cross my mind that ':' was not the type annotation in Rust itself.

is not an `i32`, so we *must* acquire the lock to be able to use the `i32` value. We
can’t forget; the type system won’t let us access the inner `i32` otherwise.

As you might suspect, `Mutex<T>` is a smart pointer. More accurately, the call
Expand Down