Clean up trait MiniscriptKey
#371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of refactoring the trait `MiniscriptKey`; improve the rustdocs on the trait.
In preparation for refactoring the `MiniscriptKey` implementations add regression tests.
The `MiniscriptKey` trait has a default implementation for `is_uncompressed` that returns `false`. No need to re-implement it.
Do minor improvement to the docs for the `bitocin::PublicKey` implementation of `is_uncompressed`.
All the non-string keys use hash160 hashes, we can simplify the logic by mirroring the current implementation for `XOnlyPublicKey`.
sanket1729
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the code around trait
MiniscriptKeyby doing