Skip to content

Clean up the manifest #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Clean up the manifest #369

merged 3 commits into from
Apr 27, 2022

Conversation

tcharding
Copy link
Member

Do trivial clean up to the manifest file.

Warning: Totally non-urgent, possibly annoyingly trivial.

Mirror the metadata in `rust-bitcoin` by:

- Updating the 'repository' entry to the `rust-bitcoin` github org
- Adding a 'homepage' entry
- Add a 'keywords' entry (use the cringy 'crypto' keyword)
- Add a 'readme' entry
- Order the entries as is done in `rust-bitcoin` for uniformity
Currently we are using the 'single section per dependecy' dependency
format, it is less unusual (at least for those working on the
`rust-bitcoin` stack) to have all the dependencies in a single section.
In the `use-serde` feature we enable `serde` and also enable it in our
dependencies. Put `serde` first in the list under the philosophy of
'most important thing first'. This is only subjectively better.
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 229db94

@sanket1729 sanket1729 merged commit dcc9d0f into rust-bitcoin:master Apr 27, 2022
@tcharding tcharding deleted the manifest branch April 27, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants