Skip to content

Run the linter #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run the linter #219

wants to merge 1 commit into from

Conversation

tcharding
Copy link
Member

Clippy emits a bunch of warnings of form:

lifetime flowing from input to output with different syntax can be confusing

Fix them as suggested by using the anonymous lifetime.

@apoelstra
Copy link
Member

Thanks! Can you also run the formatter?

If you're really motivated I think it'd be ok to migrate the whole rust-bitcoin CI infrastructure here. (I've done it in https://github.com/ElementsProject/rust-elements/ say if you want a simpler case to copy)

@tcharding
Copy link
Member Author

Thanks! Can you also run the formatter?

Can do.

If you're really motivated I think it'd be ok to migrate the whole rust-bitcoin CI infrastructure here. (I've done it in https://github.com/ElementsProject/rust-elements/ say if you want a simpler case to copy)

Hot potato - cc @jamillambert?

Clippy emits a bunch of warnings of form:

 lifetime flowing from input to output with different syntax can be confusing

Fix them as suggested by using the anonymous lifetime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants