update build to latest duckdb #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kayrnt
commented
Jul 29, 2023
| @@ -36,13 +38,13 @@ clean: | |||
|
|
|||
| # Main build | |||
| debug: | |||
| mkdir -p build/debug && \ | |||
| cmake $(GENERATOR) $(FORCE_COLOR) $(EXTENSION_FLAGS) ${CLIENT_FLAGS} -DEXTENSION_STATIC_BUILD=1 -DCMAKE_BUILD_TYPE=Debug ${BUILD_FLAGS} -S ./duckdb/ -B build/debug && \ | |||
| mkdir -p build/debug && \ | |||
There was a problem hiding this comment.
-DEXTENSION_STATIC_BUILD=1 is already in the ${BUILD_FLAGS} so it's just a clean up
Kayrnt
commented
Jul 29, 2023
Comment on lines
+26
to
+28
| EXT_NAME="odbc_scanner" | ||
| EXT_NAME_UPPERCASE=$(shell echo $(EXT_NAME) | tr '[:lower:]' '[:upper:]') | ||
| EXTENSION_FLAGS=-DDUCKDB_EXTENSION_NAMES=${EXT_NAME} -DDUCKDB_EXTENSION_${EXT_NAME_UPPERCASE}_PATH="$(PROJ_DIR)" -DDUCKDB_EXTENSION_${EXT_NAME_UPPERCASE}_SHOULD_LINK="TRUE" -DDUCKDB_EXTENSION_${EXT_NAME_UPPERCASE}_LOAD_TESTS="FALSE" -DDUCKDB_EXTENSION_${EXT_NAME_UPPERCASE}_INCLUDE_PATH="$(PROJ_DIR)src/include" |
There was a problem hiding this comment.
I extracted the odbc_scanner string to reuse it the way DuckDB parse it in its CMake
The actual changes are:
DDUCKDB_OOT_EXTENSION->DDUCKDB_EXTENSION- new required flag
-DDUCKDB_EXTENSION_${EXT_NAME_UPPERCASE}_LOAD_TESTS="FALSE"(I don't know we want it false or not, but at least it works)
Kayrnt
commented
Jul 29, 2023
| @@ -75,7 +75,7 @@ to the correct version of `unixodbc`. | |||
|
|
|||
| ```shell | |||
| nix run .#build | |||
| ./build/release/duckdb | |||
| ./build/release/duckdb -unsigned | |||
There was a problem hiding this comment.
not required but I thought it was relevant as we are going to load the unsigned extension later on
|
Looking good. I'm getting this error when building on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to build the extension against latest DuckDB version (
v0.8.2-dev2278)Don't forget to do a
make pullto retrieve the updated git submodule of DuckDB