Fix invalid use of IP addresses in SNI #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server Name Indication does not allow IP addresses (RFC 6066, section 3: `Literal IPv4 and IPv6 addresses are not permitted in "HostName".`). Recent versions of LibreSSL enforce this requirement, and the tests currently break when running on such versions. Use localhost instead of 127.0.0.1 to avoid the issue. This requires adding HTTPSNITest#connect, because s.hostname= is called before ssl_socket_connect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server Name Indication does not allow IP addresses (RFC 6066, section 3:
Literal IPv4 and IPv6 addresses are not permitted in "HostName".).Recent versions of LibreSSL enforce this requirement, and the tests
currently break when running on such versions. Use localhost
instead of 127.0.0.1 to avoid the issue. This requires adding
HTTPSNITest#connect, because s.hostname= is called before
ssl_socket_connect.