Remove rubyforge_page functionality #2436

Schwad · 2018-10-15T13:42:25Z

Description:

Type: Cleanup

RubyForge was sunsetted in 2013 . There are still mentions of it in the code base. For this PR, instead of looking for dead links I aimed to clear out the rubyforge_project attr_accessor from the rubygems specification and the places that reference it.

Perhaps there could be a conversation here whether something could 'replace', rubyforge_project (github_project?) but to start here is the 'lite' approach that simply removes it.

Looking forward to thoughts and feedback! :)

Tasks:

Describe the problem / feature
Write tests (n/a)
Write code to solve the problem
Get code review from coworkers / friends

I will abide by the code of conduct.

bronzdoc · 2018-10-15T14:19:55Z

There is Bundler code that is bening tested with rubyforge_project that needs to me modified too

hsbt · 2018-10-15T23:31:31Z

I'm okay to merge this. But The 15000+ gems still uses rubyforge_project. Like this.

...
active_presenter-3.2.2/lib/tasks/gem.rake:  s.rubyforge_project     = 'active_presenter'
active_press-0.1.0/active_press.gemspec:  s.rubyforge_project = "active_press"
active_reaper-0.0.2/active_reaper.gemspec:  s.rubyforge_project = "active_reaper"
...

We need to add the migration step that is the only attr_writer.

Schwad · 2018-10-16T12:17:38Z

@hsbt thanks for the feedback and @bronzdoc thank you for the review as well.

What I will look to do is keep the removals but utilize attr_writer :rubyforge_project as suggested to keep existing gems from breaking.

Since we have access to Gem::Deprecate, would it be wise to implement deprecate as well?

deprecate :rubyforge_project, :none, 2020, 4

Schwad · 2018-10-16T21:15:43Z

I will see how the checks go, I have reincluded an attr_writer one-liner and utilized deprecate as well.

simi · 2018-10-16T21:52:18Z

test/rubygems/test_gem_specification.rb

-
-    data = Marshal.load Gem::Util.inflate(Gem.read_binary(path))
-
-    assert_nil data.rubyforge_project


Can't we just change assertion in here? What's purpose of this test?

I went through the history (blame) on this file and the latest commits on each line weren't too illuminating: https://github.com/rubygems/rubygems/blame/master/test/rubygems/test_gem_specification.rb

However nothing about this test makes me think that rubyforge_project is the necessary component. We can flag up some other authors but I could preserve this test with the assertion looking at a different attribute. (say 'description'). Will commit that now.

Yup, that's what I was thinking about as well. It is not clear what's the purpose of this test at all, but it is probably not directly testing rubyforge_project, but uses rubyforge_project to assert only. Changing assertion to use different attribute should work here also.

Interestingly enough, as I just found out, description does not assert nil. I am wondering if this is only actually passing on an assert_nil because rubyforge_project simply isn't set anymore.....

Schwad · 2018-10-17T10:26:23Z

I am guessing failures like this: https://travis-ci.org/rubygems/rubygems/jobs/442597902 will require bundler changes.

Failures like this: https://travis-ci.org/rubygems/rubygems/jobs/442597895 will require further understanding about what the test is looking to achieve. Open to thoughts on this or a decision if we can greenlight its removal.

segiddins · 2018-10-17T16:48:29Z

lib/rubygems/specification.rb

    spec.instance_variable_set :@required_rubygems_version, array[7]
    spec.instance_variable_set :@original_platform,         array[8]
    spec.instance_variable_set :@dependencies,              array[9]
-    spec.instance_variable_set :@rubyforge_project,         array[10]


I think this change would require bumping the spec version -- it might be better to keep the offsets the same, and just never use the rubyforge ivar?

👍 for keeping the offsets the same. You should probably also add a note explaining that it's deprecated/no longer used.

Schwad · 2018-10-25T14:41:20Z

Okay, I'll redo the offsets. It looks like the bundler failure (referenced in another PR) is due to it tying to an older version of `rake` which still uses `rubyforge_project` and they won't be able to bump it until `bundler 2.0`. What I may do to 'get this over the line' is keep offsets the same, add a note, and save adding the `deprecate` line on the `attr_writer` until bundler accepts my bump PR in the future.

…

On Wed, 24 Oct 2018 at 20:19, Ellen Marie Dash ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/rubygems/specification.rb <#2436 (comment)>: > @@ -1349,16 +1348,15 @@ def self._load(str) spec.instance_variable_set ***@***.***_rubygems_version, array[7] spec.instance_variable_set ***@***.***_platform, array[8] spec.instance_variable_set ***@***.***, array[9] - spec.instance_variable_set ***@***.***_project, array[10] 👍 for keeping the offsets the same. You should probably also add a note explaining that it's deprecated/no longer used. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2436 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgCxmndAW4jMUmKdFqYud0-PvQZ1GSWks5uoL0qgaJpZM4XcXcY> .

Schwad · 2018-10-25T14:41:36Z

Should have something up monday -just replying from email On Thu, 25 Oct 2018 at 15:41, Nicholas Schwaderer < [email protected]> wrote:

…

Okay, I'll redo the offsets. It looks like the bundler failure (referenced in another PR) is due to it tying to an older version of `rake` which still uses `rubyforge_project` and they won't be able to bump it until `bundler 2.0`. What I may do to 'get this over the line' is keep offsets the same, add a note, and save adding the `deprecate` line on the `attr_writer` until bundler accepts my bump PR in the future. On Wed, 24 Oct 2018 at 20:19, Ellen Marie Dash ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In lib/rubygems/specification.rb > <#2436 (comment)>: > > > @@ -1349,16 +1348,15 @@ def self._load(str) > spec.instance_variable_set ***@***.***_rubygems_version, array[7] > spec.instance_variable_set ***@***.***_platform, array[8] > spec.instance_variable_set ***@***.***, array[9] > - spec.instance_variable_set ***@***.***_project, array[10] > > 👍 for keeping the offsets the same. You should probably also add a note > explaining that it's deprecated/no longer used. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#2436 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AHgCxmndAW4jMUmKdFqYud0-PvQZ1GSWks5uoL0qgaJpZM4XcXcY> > . >

Schwad · 2018-10-25T14:56:00Z

Update - reference this in bundler and will do another PR in future with the full deprecation line so that we can move forward without breaking tests. Will make that change after bundler 2.0

Current changes restored offsets and removed explicit deprecation.

deivid-rodriguez · 2018-12-04T10:15:39Z

So @Schwad, I take it this is ready to go now, right?

Great job here, I think there's some other attributes where we could do the same thing, for example, test_files.

Schwad · 2018-12-06T13:18:13Z

@deivid-rodriguez just had a look, yes we should be good to go for this!

bronzdoc · 2018-12-10T13:02:00Z

@bundlerbot r+

2436: Remove rubyforge_page functionality r=bronzdoc a=Schwad # Description: Type: Cleanup RubyForge was [sunsetted in 2013](https://twitter.com/evanphx/status/399552820380053505) . There are still mentions of it in the code base. For this PR, instead of looking for dead links I aimed to clear out the `rubyforge_project` attr_accessor from the rubygems specification and the places that reference it. Perhaps there could be a conversation here whether something could 'replace', `rubyforge_project` (`github_project`?) but to start here is the 'lite' approach that simply removes it. Looking forward to thoughts and feedback! :) ______________ # Tasks: - [x] Describe the problem / feature - [ ] Write tests __(n/a)__ - [x] Write code to solve the problem - [x] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). 2511: Better unrestricted warning r=bronzdoc a=deivid-rodriguez # Description: This is a possible fix for #2508. If the dependency is fully unrestricted, give a generic message instead of guessing what the user wants, since we cannot really know it. ______________ # Tasks: - [x] Describe the problem / feature - [x] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md). Co-authored-by: Nick Schwaderer <[email protected]> Co-authored-by: Nick Schwaderer <[email protected]> Co-authored-by: David Rodríguez <[email protected]>

ghost · 2018-12-10T13:51:32Z

Build succeeded

continuous-integration/travis-ci/push

Rubyforge was closed down in 2013 [1]. The rubyforge_project property was deprecated in rubygems in pull request 2436 [2]. [1] https://twitter.com/evanphx/status/399552820380053505 [2] ruby/rubygems#2436

RubyForge was closed down in 2013 [1]. The `rubyforge_project` property was deprecated in rubygems in pull request 2436 [2]. [1] https://twitter.com/evanphx/status/399552820380053505 [2] ruby/rubygems#2436

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

RubyForge was closed down in 2013 [1]. The `rubyforge_project` property was deprecated in rubygems in pull request 2436 [2]. [1] https://twitter.com/evanphx/status/399552820380053505 [2] ruby/rubygems#2436

RubyForge was sunsetted in 2013. ref. ruby/rubygems#2436

The RubyGems gemspec property rubyforge_project has been removed without a replacement. ## Background * [RubyForge was closed down in 2013][1]. * [ruby/rubygems#2436 deprecated the `rubyforge_project` property][2]. [1]: https://twitter.com/evanphx/status/399552820380053505 [2]: ruby/rubygems#2436

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. This PR removes that property. Background: - RubyForge was closed down in 2013, https://twitter.com/evanphx/status/399552820380053505 - ruby/rubygems#2436 deprecated the `rubyforge_project` property

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. This PR removes that property. Background: - RubyForge was closed down in 2013, https://twitter.com/evanphx/status/399552820380053505 - ruby/rubygems#2436 deprecated the `rubyforge_project` property

Remove rubyforge_page functionality

ed1ac63

bronzdoc added the status: triage label Oct 15, 2018

bronzdoc approved these changes Oct 15, 2018

View reviewed changes

Prevents gem breaking from rubyforge removal, makes deprecation vocal

dfe5fa6

simi reviewed Oct 16, 2018

View reviewed changes

Nick Schwaderer added 4 commits October 17, 2018 10:13

Point test to non-deprecated specification attribute

0935f38

Merge branch 'master' of http://github.com/schwad/rubygems

3dbfa8a

Deprecate rubyforge_project with same approach as has_rdoc

6cbdf43

Deprecate rubyforge_project as default_executable

ef83406

Schwad mentioned this pull request Oct 17, 2018

Bump rake version rubygems/bundler#6745

Closed

Checks against default_executable attribute

bd9b003

segiddins reviewed Oct 17, 2018

View reviewed changes

Remove rubyforge deprecation, restore offset

d3bcc8f

Nick Schwaderer added 2 commits October 25, 2018 15:57

➕ :

57bc545

empty string to preserve rubyforge_project

a959a2f

deivid-rodriguez approved these changes Dec 6, 2018

View reviewed changes

bronzdoc approved these changes Dec 10, 2018

View reviewed changes

olleolleolle mentioned this pull request Jul 15, 2019

Gemspec: Drop deprecated and ignored property adhearsion/ruby_speech#55

Merged

olleolleolle mentioned this pull request Jul 15, 2019

Gemspec: drop rubyforge_project property adhearsion/adhearsion-asterisk#18

Merged

drwl pushed a commit to ctran/annotate_models that referenced this pull request Jul 16, 2019

Gemspec: drop rubyforge_project, it is EOL (#639)

574cc61

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

olleolleolle mentioned this pull request Jul 22, 2019

Gemspec: drop EOL'd rubyforge_project, has_rdoc braintree/braintree_ruby#186

Merged

2 tasks

ryanwjackson pushed a commit to ryanwjackson/annotate_models that referenced this pull request Aug 6, 2019

Gemspec: drop rubyforge_project, it is EOL (ctran#639)

494697e

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

yujideveloper mentioned this pull request Nov 18, 2019

Delete rubyforge_project= in gemspec mirakui/ec2ssh#51

Merged

yujideveloper added a commit to yujideveloper/ec2ssh that referenced this pull request Nov 18, 2019

Delete rubyforge_project= in gemspec

452ac2a

RubyForge was sunsetted in 2013. ref. ruby/rubygems#2436

peterfication pushed a commit to store2be/annotate_models that referenced this pull request Jan 20, 2020

Gemspec: drop rubyforge_project, it is EOL (ctran#639)

262bd07

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

olleolleolle mentioned this pull request Mar 3, 2020

gemspec: Drop defunct rubyforge_project directive brendon/acts_as_list#373

Merged

This was referenced Apr 11, 2020

gemspec: Drop defunct property rubyforge_project sunspot/sunspot#976

Merged

gemspec: Drop defunct property rubyforge_project wsargent/circuit_breaker#24

Merged

fatcatt316 mentioned this pull request Apr 14, 2020

Clean up output of rake test:local activemerchant/active_merchant#3598

Closed

6 tasks

vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020

Gemspec: drop rubyforge_project, it is EOL (ctran#639)

1c7d2dc

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

olleolleolle mentioned this pull request May 27, 2020

gemspec: Drop rubyforge_project directive mdub/sham_rack#12

Open

This was referenced Jul 8, 2020

gemspec: Drop rubyforge reference savonrb/httpi#212

Merged

gemspec: Drop unused rubyforge_project property savonrb/nori#83

Merged

gemspec: Drop old property rubyforge_project savonrb/akami#38

Merged

olleolleolle mentioned this pull request Mar 26, 2021

gemspec: Drop defunct rubyforge_project directive savonrb/gyoku#74

Merged

olleolleolle mentioned this pull request May 25, 2021

gemspec: Drop unused rubyforge_project directive eigenben/nilify_blanks#50

Merged

olleolleolle mentioned this pull request Oct 8, 2021

gemspec: Remove unused directives ruby-amqp/march_hare#159

Merged

dazralsky pushed a commit to dazralsky/annotate_models that referenced this pull request Aug 21, 2023

Gemspec: drop rubyforge_project, it is EOL (#639)

5693b8e

The RubyGems gemspec property `rubyforge_project` has been removed without a replacement. Refer to ruby/rubygems#2436

This pull request was closed.


		data = Marshal.load Gem::Util.inflate(Gem.read_binary(path))

		assert_nil data.rubyforge_project

Uh oh!

Remove rubyforge_page functionality #2436

Remove rubyforge_page functionality #2436

Uh oh!

Conversation

Schwad commented Oct 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Tasks:

Uh oh!

bronzdoc commented Oct 15, 2018

Uh oh!

hsbt commented Oct 15, 2018

Uh oh!

Schwad commented Oct 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Schwad commented Oct 16, 2018

Uh oh!

simi Oct 16, 2018

Choose a reason for hiding this comment

Uh oh!

Schwad Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

simi Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

Schwad Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

Schwad commented Oct 17, 2018

Uh oh!

segiddins Oct 17, 2018

Choose a reason for hiding this comment

Uh oh!

duckinator Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

Schwad commented Oct 25, 2018 via email

Uh oh!

Schwad commented Oct 25, 2018 via email

Uh oh!

Schwad commented Oct 25, 2018

Uh oh!

deivid-rodriguez commented Dec 4, 2018

Uh oh!

Schwad commented Dec 6, 2018

Uh oh!

bronzdoc commented Dec 10, 2018

Uh oh!

ghost commented Dec 10, 2018

Build succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Schwad commented Oct 15, 2018 •

edited

Loading

Schwad commented Oct 16, 2018 •

edited

Loading