Accept REXML::Document.new("") for backward compatibility
#295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Sep 9, 2025
naitoh
force-pushed
the
update_compatibility
branch
from
a41f3cc to
248f0de
Compare
kou
reviewed
Sep 10, 2025
kou
changed the title
REXML::Document.new("") to behave the same as REXML::Document.new(nil)REXML::Document.new("") for backward compatibility
…nt.new(nil)`
## Why?
XML without a root element is invalid XML, but to maintain compatibility,
we will change the behavior of `REXML::Document.new("")` to be the same as `REXML::Document.new(nil)`.
naitoh
force-pushed
the
update_compatibility
branch
from
248f0de to
fd9f75a
Compare
kou
reviewed
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
GitHub: Fix GH-296
XML without a root element is invalid XML, but to maintain backward compatibility,
we will change the behavior of
REXML::Document.new("")to be the same asREXML::Document.new(nil).Reported by Joe Rafaniello. Thanks!!!