Skip to content

Fix tag in table_of_contents.html #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Nov 8, 2017

RDoc::Markup::AttributeManager#convert_html that is called from RDoc::Markup::AttributeManager#flow replaces HTML tags of received str with NULL characters in HTML generation for each files, and the NULL characters are removed in RDoc::Markup::AttributeManager#split_into_flow. But the String objects are reused for table_of_contents.html generation, so the tags lose at that moment.

This Pull Request fixes it with using duplicated String object.

@aycabta aycabta force-pushed the fix-tag-in-table_of_contents branch from a2f53fa to 1fe8541 Compare November 8, 2017 17:44
RDoc::Markup::AttributeManager#convert_html that is called from
RDoc::Markup::AttributeManager#flow replaces HTML tags of received "str"
with "NULL" characters in HTML generation for each files, and the NULL
characters are removed in
RDoc::Markup::AttributeManager#split_into_flow. But the String objects
are reused for table_of_contents.html generation, so the tags lose at
that moment.

This commit fixes it with using duplicated String object.
@aycabta aycabta force-pushed the fix-tag-in-table_of_contents branch from 1fe8541 to dcdf4bf Compare November 8, 2017 17:47
@aycabta
Copy link
Member Author

aycabta commented Nov 8, 2017

This depends on #550 for that CI passes tests.

@hsbt hsbt merged commit 60926a9 into ruby:master Nov 10, 2017
@aycabta aycabta deleted the fix-tag-in-table_of_contents branch November 10, 2017 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants