Handle all definitions per file in Ruby #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::Parser::C cann't discern each documents per file for one class, so RDoc::ClassModule adopts the latest comment per file, however RDoc::Parser::Ruby can take each documents per file for one class. This commit changes the behavior only when RDoc::ClassModule is for RDoc::Parser::C. Of course this works around RDoc::Parser::C.
|
I understood detail of this fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDoc::Parser::Ccann't discern each documents per file for one class, soRDoc::ClassModuleadopts the latest comment per file, howeverRDoc::Parser::Rubycan take each documents per file for one class. This commit changes the behavior only whenRDoc::ClassModuleis forRDoc::Parser::C. Of course this works aroundRDoc::Parser::C.And I checked all CRuby's documents and 2 documents change with this patch because the class/module has re-definition line without document after first definition line with document. Those are
ERB(re-definitions without document: 1, 2, 3, 4) andDRb::DRbProtocol(re-definition without document). Those documents are lost now, and with this patch, those become to be treated correctly.ref. ecae6cb, d84ada2, e033904
This closes #180.