Skip to content

[DOC] RDoc for additions#548

Closed
BurdetteLamar wants to merge 9 commits intoruby:masterfrom
BurdetteLamar:additions_doc
Closed

[DOC] RDoc for additions#548
BurdetteLamar wants to merge 9 commits intoruby:masterfrom
BurdetteLamar:additions_doc

Conversation

@BurdetteLamar
Copy link
Copy Markdown
Member

@BurdetteLamar BurdetteLamar commented Nov 16, 2023

I realized in working with BigDecimal here that the user is most like to pair the serialize/deserialize operations, so have written accordingly.

@BurdetteLamar BurdetteLamar marked this pull request as draft November 21, 2023 21:08
@BurdetteLamar BurdetteLamar marked this pull request as ready for review November 25, 2023 21:07
@BurdetteLamar
Copy link
Copy Markdown
Member Author

@hsbt, I don't think I caused these failed checks, but please correct me if I'm wrong.

@BurdetteLamar
Copy link
Copy Markdown
Member Author

@hsbt, @nurse: Will either of you be reviewing this? If not, is there someone else I should ask?

@hsbt
Copy link
Copy Markdown
Member

hsbt commented Dec 1, 2023

@BurdetteLamar I exclude truffleruby-head from CI at #551. You can resolve CI failure with git rebase.

@BurdetteLamar
Copy link
Copy Markdown
Member Author

@BurdetteLamar I exclude truffleruby-head from CI at #551. You can resolve CI failure with git rebase.

@hsbt, I was not able to do this. Can you (or someone else) resolve this?

@BurdetteLamar
Copy link
Copy Markdown
Member Author

As I said earlier, I was not able to untangle this PR. If no one objects, I'll close it and start fresh with a new PR; there's no technical review so far, so I think nothing would be lost.

@BurdetteLamar
Copy link
Copy Markdown
Member Author

Putting into new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants