Remove unknown keyword arg from DateTime.parse#488
Merged
hsbt merged 1 commit intoruby:masterfrom Dec 2, 2021
Merged
Conversation
This snuck in while addding tests for the `create_additions` feature. Caught by JRuby when we added the `limit` option to the Date/DateTime parsing methods, which causes this to be rejected as an unknown keyword.
Contributor
Author
|
We opted to exclude this test in jruby/jruby@a9f3b6b because it started to fail when we added the This was not found by CRuby because the option processing in CRuby's date library does not reject unknown keywords. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This snuck in while addding tests for the
create_additionsfeature. Caught by JRuby when we added the
limitoption to theDate/DateTime parsing methods, which causes this to be rejected as
an unknown keyword.