Mark Closure, Function and Handle as write barrier protected #129
Conversation
casperisfine
force-pushed
the
dummy-write-barriers
branch
from
a3e74fb to
a4e7a6f
Compare
They don't have a mark function, so they don't need any change.
casperisfine
force-pushed
the
dummy-write-barriers
branch
from
a4e7a6f to
ed014aa
Compare
| .dfree = fiddle_handle_free, | ||
| .dsize = fiddle_handle_memsize | ||
| }, | ||
| .flags = RUBY_TYPED_WB_PROTECTED, |
There was a problem hiding this comment.
Can we specify RUBY_TYPED_FREE_IMMEDIATELY here too?
There was a problem hiding this comment.
Maybe?
The reason I didn't add it is that the dfree function calls dlclose and I don't know all the characteristics of it, so I don't know if it's safe to call from the GC.
There was a problem hiding this comment.
I see.
I think that we can add it after we improve Fiddle::Handle#[] to refer Fiddle::Handle from the returned symbol. We can ensure keeping Fiddle::Handle while its symbols are referred.
| .dfree = fiddle_handle_free, | ||
| .dsize = fiddle_handle_memsize | ||
| }, | ||
| .flags = RUBY_TYPED_WB_PROTECTED, |
There was a problem hiding this comment.
I see.
I think that we can add it after we improve Fiddle::Handle#[] to refer Fiddle::Handle from the returned symbol. We can ensure keeping Fiddle::Handle while its symbols are referred.
protected (ruby/fiddle#129) They don't have a mark function, so they don't need any change. ruby/fiddle@9bbc732aef Co-authored-by: Jean Boussier <[email protected]>
They don't have a mark function, so they don't need any change.