Skip to content

Remove test-queue to reduce time taken to run tests - #349

Merged
koic merged 1 commit into
rubocop:masterfrom
tejasbubane:remove-test-queue
Jun 12, 2026
Merged

Remove test-queue to reduce time taken to run tests#349
koic merged 1 commit into
rubocop:masterfrom
tejasbubane:remove-test-queue

Conversation

@tejasbubane

@tejasbubane tejasbubane commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

For a small repository, queue is an overhead. Running minitest tests directly are much more performant.

On my machine: time bundle exec rake test
test-queue takes 16.44s
direct minitest takes 1.50s.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@andyw8

andyw8 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

There are a couple of remaining references to test-queue:

  • .github/workflows/test.yml
  • Rakefile (the "JRuby and Windows..." branch can be removed)

@koic

koic commented Jun 10, 2026

Copy link
Copy Markdown
Member

@tejasbubane ping.

For a small repository, queue is an overhead. Running minitest tests
directly are much more performant.

On my machine test-queue takes `16.44s` while direct minitest takes
`1.50s`. That is almost 10x reduction.
@tejasbubane

Copy link
Copy Markdown
Contributor Author

Thanks. Removed both references. cc @koic

@koic
koic merged commit 19ce000 into rubocop:master Jun 12, 2026
16 checks passed
@tejasbubane
tejasbubane deleted the remove-test-queue branch June 12, 2026 15:54
Comment thread Rakefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants