Remove test-queue to reduce time taken to run tests - #349
Merged
Conversation
Contributor
|
There are a couple of remaining references to test-queue:
|
Member
|
@tejasbubane ping. |
For a small repository, queue is an overhead. Running minitest tests directly are much more performant. On my machine test-queue takes `16.44s` while direct minitest takes `1.50s`. That is almost 10x reduction.
tejasbubane
force-pushed
the
remove-test-queue
branch
from
June 11, 2026 16:04
58761c1 to
857732d
Compare
Contributor
Author
|
Thanks. Removed both references. cc @koic |
andyw8
approved these changes
Jun 11, 2026
8 tasks
bquorning
reviewed
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a small repository, queue is an overhead. Running minitest tests directly are much more performant.
On my machine:
time bundle exec rake testtest-queue takes
16.44sdirect minitest takes
1.50s.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.