Deletes everything when hitting the max database size. (React Native - Android)

[ksegla]

Hi, thanks for the great module.
I'm using this (probably improperly) as a quick (and temporary) way to store data (list of things) relevant for my app users.
In any case, I ran into a problem recently. When it hits the maximum size (6MB by default for React Native onAndroid), it just deletes (or at least fails to render) any stored data. Which would have had disastrous effects if the app was already launched.
Ideally, it would just fail updating the database, not destroy it.
Thanks for considering fixing this

[rt2zz]

AsyncStorage stores everything in one JSON file, so while I have never hit the limit, I can imagine bad things happen when you do. Two possible options off the top of my head:

• implement a SQLLite or similar storage backend
• we can detect if the storage save errors and if so resave the previous state (this seems brittle however.

Open to others ideas

[ksegla]

Obviously Option 1 is better and would be great but even Option 2 would be vastly better than the state's wipe out. As I understood it, Option 1 would do more than just fix the problem I had. In my specific case, may be there could be some kind of quick check on the new information size and a verification on whether it could hit the size limit. Note that the limit for AsyncStorage can be changed in the MainApplication.java (it can be more than 6MB)

[nhayfield]

i started building a new store but haven't been able to integrate it yet: sriraman/react-native-shared-preferences#5
and
https://github.com/nhayfield/react-native-shared-preferences
i may continue but i'm going to attempt to up the storage limit for asyncstorage first based on this:
https://github.com/facebook/react-native/pull/11656/files

[nitkuk]

Even after changing maximum database size limit to 50 MB, it is wiping the state.

Here is how I did it:
In Main Application, inside getPackages(), I wrote this code..
long size = 50L * 1024L * 1024L; // 50 MB com.facebook.react.modules.storage.ReactDatabaseSupplier.getInstance(getApplicationContext()).setMaximumSize(size);

Only difference I find is app is not showing disk full warning in debug.
Can someone give some pointer?

[ptomasroos]

Thanks. I will look into this in a while. Currently shipping a release. I will let you know later this week.

[frostney]

@nitkuk If you increase the database size inside of getPackages(), it might not have the desired effect. At least that was the case for me.

Putting the call inside of onCreate of MainApplication, as outlined in facebook/react-native#11656 worked for me.

Edit: After testing this again, it turns out it didn't have any effect on where the piece of code was placed and I have the same exact issue.

[nhayfield]

@nitkuk I set it to 8gb and now it works pretty good lol

[robwalkerco]

I've just worked around this issue by writing my own storage implementation for Android that uses the file system rather than AsyncStorage.

Details at - #284 (comment)

[robwalkerco]

I've just published an npm module specifically to fix this issue.
Check out https://www.npmjs.com/package/redux-persist-filesystem-storage

[MichaelDanielTom]

Quick question @robwalkerco, is performance in your library better, worse, or the same as vanilla redux-persist that uses AsyncStorage on Android?

[robwalkerco]

I've not benchmarked it @MichaelDanielTom, but I'm using it in production and haven't noticed any issues or slowness, though I have also been using the debounce option in redux-persist to reduce the number of writes. Think I set it to 50ms.

Please do share any benchmark results though, if you run any.

[ksegla]

So unfortunately, the problem is still there, even with redux-persist-filesystem-storage :-(
Any possible lead on where to start in the source code if I wanted to fix the issue myself?
Thanks

[robwalkerco]

@ksegla, redux-persist used AsyncStorage by default, which on Android uses sqlite, which imposes a storage limit. redux-persist-filesystem-storage gets around this by using the filesystem instead of AsyncStorage, and so does not have a limit on the storage size (as far as I understand).

It therefor leads to me wonder if you are hitting the actual physical storage limit of your device? i.e. The device is refusing to store any more data in any location, as its run out of space. Could this be your issue?