Skip to content

⭐ add(css_varriables): Add variables for bar height and color #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2020

Conversation

anselal
Copy link

@anselal anselal commented Apr 4, 2020

I added 2 variables, and formatted the css file

@rstacruz
Copy link
Owner

Thanks - let me roll this in with the next version on #218.

I'd prefer the variable names to be prefixed (eg, --nprogress-color) so it plays well with other libraries. It'd also be great if there are non-variable fallbacks for the benefit of legacy browsers. I'm going to implement them over at #218.

Thanks for your contribution!

@rstacruz rstacruz merged commit 7b3d99a into rstacruz:rstacruz-2020-04-04 Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants