Skip to content

Prevent travis build from failing to install properly Google chrome #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2020
Merged

Prevent travis build from failing to install properly Google chrome #2336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9425f2
Revert skipping feature test with Selenium driver and wrong exit status
benoittgt May 16, 2020
e674023
Prevent error when installing chromedriver
benoittgt May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ addons:
chrome: stable
apt:
packages:
- dpkg
- chromium-chromedriver

# We deviate from the rspec-dev cache setting here.
Expand Down
8 changes: 0 additions & 8 deletions features/step_definitions/additional_cli_steps.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,3 @@
pending "Action Cable testing is not available"
end
end

Then "the exit status should be 0 (ignoring CI failure)" do
begin
step "the exit status should be 0"
rescue Exception => e # rubocop:disable Lint/RescueException
raise e unless ENV['CI']
end
end
2 changes: 1 addition & 1 deletion features/system_specs/system_specs.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ Feature: System spec
When I run `rspec spec/system/widget_system_spec.rb`
Then the output should contain "1 example, 0 failures"
And the output should not contain "starting Puma"
And the exit status should be 0 (ignoring CI failure)
And the exit status should be 0