feat!: work with Storybook v10 #388
Conversation
✅ Deploy Preview for storybook-rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fi3ework
force-pushed
the
v10
branch
8 times, most recently
from
8bf388f to
25177ef
Compare
fi3ework
force-pushed
the
v10
branch
5 times, most recently
from
07532ff to
df8a35a
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pkgJson.exports = { | ||
| './package.json': './package.json', | ||
| ...data.extraOutputs, |
There was a problem hiding this comment.
The new build pipeline always spreads data.extraOutputs into pkgJson.exports. For most packages the build config does not set extraOutputs, so invoking scripts/build/build-package.ts (e.g. via pnpm --filter "./packages/*" run build or prep) throws TypeError: Cannot convert undefined or null to object before bundling even starts. This prevents all packages without extraOutputs (frameworks, addons) from building. Add a default or conditional spread so packages without extra outputs can be built.
Useful? React with 👍 / 👎.
resolve #364.
maintov2@module-federation/storybook-addonto v5