OracleEnhanced::Quoting::NONQUOTED_OBJECT_NAME has "hard-coded" identifier length

[yahonda]

Steps to reproduce

#1703 introduces longer identifier support. However, there is hardcoded value expecting shorter identifier length, 30 bytes.

Expected behavior

OracleEnhanced::Quoting::NONQUOTED_OBJECT_NAME or equivalent should return value depending on max_identifier_length introduced in #1703.

Actual behavior

OracleEnhanced::Quoting::NONQUOTED_OBJECT_NAME has hard coded{0,29} in NONQUOTED_OBJECT_NAME = /[[:alpha:]][\w$#]{0,29}/

System configuration

Rails version:master

Oracle enhanced adapter version:master

Ruby version:ruby 2.6.0dev (2018-04-16 trunk 63163) [x86_64-linux]

Oracle Database version:Oracle Database 12c Enterprise Edition Release 12.2.0.1.0 - 64bit Production

[yahonda]

These specs also need updating to support longer identifier.

oracle-enhanced/spec/active_record/connection_adapters/oracle_enhanced/quoting_spec.rb

Lines 105 to 111 in e63142b

	it "should not be valid for names > 30 characters" do
	expect(@adapter.valid_table_name?("a" * 31)).to be_falsey
	end
	it "should not be valid for schema names > 30 characters" do
	expect(@adapter.valid_table_name?(("a" * 31) + ".validname")).to be_falsey
	end

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.