This repository was archived by the owner on Oct 23, 2022. It is now read-only.
Merge ipfs-rust-conformance #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source: rs-ipfs/ipfs-rust-conformance@b979f02 Co-authored-by: ljedrz <[email protected]> Co-authored-by: Mark Henderson <[email protected]>
koivunej
commented
Jul 16, 2020
koivunej
commented
Jul 16, 2020
koivunej
commented
Jul 16, 2020
|
Patching needs to change a bit, no biggie, pushing soon. |
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
| By default, there is a `http` symlink to `../target/debug/ipfs-http`. You can | ||
| change this to the release binary by modifying the symlink or use a custom | ||
| binary via the environment variable `IPFS_RUST_EXEC`. The default `rust.sh` | ||
| wrapper will record all actions taken by the tests into a single large log |
There was a problem hiding this comment.
I think I've seen that you've suffixed the nope, mislooked - it was the recommendation 😛.log filename with .$$, so it's no longer a single big file, no?
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
ljedrz
reviewed
Jul 16, 2020
Co-authored-by: ljedrz <[email protected]>
koivunej
force-pushed
the
merge_conformance
branch
from
dbd0cda to
2576a6d
Compare
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having discussed this with @aphelionz and @ljedrz we couldn't come up a single good reason to keep this in a separate repository. History is not brought in as that would enlarge rust-ipfs repository by 30MB.