-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add options to mask texts #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @re-fort, thanks for the great PRs! The design and implementation look good to me, and there are two things I think need a discussion:
|
Thanks @Yuyz0112 !
I think that can be achieved by passing
It certainly would be nice to have a default mask function as well as |
@re-fort I like the approach you have taken for configuration and usage of this feature. |
Another suggestion is naming the options like |
@Yuyz0112 I revised docs and add some tests.(also rrweb-io/rrweb-snapshot#73) |
@re-fort All the things look great to me and I've merged the PR in snapshot repo and release a new version(1.1.2). Could you help upgrade rrweb-snapshot in this PR and pass the CI? |
@Yuyz0112 Thanks! |
This draft PR, which resolves #502, adds options to enable to mask texts.
it depends on rrweb-io/rrweb-snapshot#73
added options:
(t) => t.replace(/[a-z]/ig, '*')
)if the direction of implementation looks good, I'll add documentation and tests.