Redmine support #73
Redmine support #73
Conversation
|
|
| when Time | ||
| "'#{value.strftime("%m-%d-%Y %H:%M")}'" | ||
| when Date | ||
| "'#{value.strftime("%m-%d-%Y")}'" |
There was a problem hiding this comment.
I think the BINDDATE craziness is there for a good reason. In one of my previous PRs, I learned why this is here and explained it in the comments.
There was a problem hiding this comment.
Can you explain it here, why binddate is better solution?
| end | ||
|
|
||
| def rename_table(name, new_name) | ||
| fail ActiveRecordError, 'Firebird does not support renaming tables.' | ||
| end | ||
|
|
||
| def drop_table(name, options = {}) # :nodoc: | ||
| super |
There was a problem hiding this comment.
If the table has a sequence, you can't drop it. You need to drop the sequence first.
Unless I'm missing something, the super should come after the sequence is dropped.
| @@ -144,13 +168,19 @@ def remove_column(table_name, column_name, type = nil, options = {}) | |||
| def change_column(table_name, column_name, type, options = {}) | |||
| type_sql = type_to_sql(type, *options.values_at(:limit, :precision, :scale)) | |||
|
|
|||
| execute(squish_sql(<<-end_sql)) | |||
| if type == :text | |||
| remove_column table_name, column_name | |||
There was a problem hiding this comment.
Change column is supposed to be a "safe" operation, meaning it won't delete your data. I would say dropping a column without warning would be very unsafe.
| unless options[:sequence] == false | ||
| sequence_name = options[:sequence] || default_sequence_name(name) | ||
| drop_sequence(sequence_name) if sequence_exists?(sequence_name) | ||
| end | ||
|
|
||
| super | ||
| commit_db_transaction |
There was a problem hiding this comment.
Is there a reason for all of the commit_db_transaction invocations? execute should commit.
|
Please don't forget to run the Active Record test suite against this PR. There will be plenty of failures, but it should indicate regressions. |
Added redmine support and datetime fixes