Skip to content

Check remaining size before resizing sequences (backport #130) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Check remaining size before resizing sequences (backport #130) #131

merged 1 commit into from
Jul 18, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 3, 2025

Description

Introducing a fix for ros2/rmw_fastrtps#828 and ros2/rmw_fastrtps#797 (when backported to humble)

The idea is to check the deserialized sequence size against the remaining size in the CDR stream, and fail when insufficient.

Is this user-facing behavior change?

Did you use Generative AI?

NO

Additional Information

When backporting to Iron and earlier distributions, we would need to change calls to get_state / set_state into getState / setState

This is an automatic backport of pull request #130 done by Mergify.

@MiguelCompany @mergify
Check remaining size before resizing sequences (#130)
c6859a1 
* Check remaining size before resizing sequences

Signed-off-by: Miguel Company <[email protected]>

* Avoid linter complaining of too long function.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 7283329)
@mergify mergify bot mentioned this pull request Jul 3, 2025
Merged
@fujitatomoya
Copy link
Contributor

fujitatomoya commented Jul 3, 2025 •
edited by MiguelCompany
Loading

Pulls: ros2/rmw_implementation#262, #131, ros2/rmw_fastrtps#834
Gist: https://gist.githubusercontent.com/fujitatomoya/2de7f6632aacbe942980c110e893abfd/raw/59244297cf9268d291c393a17d5ee2889d50f959/ros2.repos
BUILD args: --packages-above-and-dependencies test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
TEST args: --packages-above test_rmw_implementation rosidl_typesupport_fastrtps_c rosidl_typesupport_fastrtps_cpp rmw_fastrtps_dynamic_cpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16403

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Jul 3, 2025
Merged
Merged
@MiguelCompany
Copy link
Collaborator

@fujitatomoya The test failures here look unrelated to me

@fujitatomoya
Copy link
Contributor

@MiguelCompany thank for checking on this. i will go ahead to merge this, ros2/rmw_fastrtps#834 and ros2/rmw_implementation#262.

@fujitatomoya fujitatomoya merged commit 3668517 into kilted Jul 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @MiguelCompany