-
Notifications
You must be signed in to change notification settings - Fork 484
add automatically_add_executor_with_node option #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add automatically_add_executor_with_node option #1594
Conversation
|
thanks for opening PR 👍 could you also take care of DCO failure https://github.com/ros2/rclcpp/pull/1594/checks?check_run_id=2183190459? |
55543bf to
5f62c9a
Compare
Signed-off-by: Brice <[email protected]>
5f62c9a to
ff3102a
Compare
Signed-off-by: Brice <[email protected]>
wjwwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, since this API is not covered by https://github.com/ros2/rclcpp/blob/master/rclcpp/test/rclcpp/test_add_callback_groups_to_executor.cpp, can you maybe add some code here to just exercise the new API?
rclcpp/rclcpp_lifecycle/test/test_lifecycle_node.cpp
Lines 663 to 675 in 0088e35
| TEST_F(TestDefaultStateMachine, test_callback_groups) { | |
| auto test_node = std::make_shared<EmptyLifecycleNode>("testnode"); | |
| auto groups = test_node->get_callback_groups(); | |
| EXPECT_EQ(groups.size(), 1u); | |
| auto group = test_node->create_callback_group( | |
| rclcpp::CallbackGroupType::MutuallyExclusive); | |
| EXPECT_NE(nullptr, group); | |
| groups = test_node->get_callback_groups(); | |
| EXPECT_EQ(groups.size(), 2u); | |
| EXPECT_EQ(groups[1].lock().get(), group.get()); | |
| } |
Signed-off-by: Brice <[email protected]>
Signed-off-by: Brice <[email protected]>
|
@ros-pull-request-builder retest this please |
This PR tries to implement #1589
It adds the
automatically_add_executor_with_nodeoption when creating a callback_group for a LifecycleNode.