Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2023

This is an automatic backport of pull request #354 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add empty set_atomically parameter service

Signed-off-by: acuadros95 <[email protected]>

* Fix cpplint

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit 688bd28)
@JanStaschulat JanStaschulat mentioned this pull request Jun 12, 2023
20 tasks
JanStaschulat and others added 2 commits June 13, 2023 11:42
Signed-off-by: Jan Staschulat <[email protected]>
Signed-off-by: acuadros95 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #358 (c81bdae) into iron (2648503) will increase coverage by 0.35%.
The diff coverage is 95.55%.

@@            Coverage Diff             @@
##             iron     #358      +/-   ##
==========================================
+ Coverage   69.20%   69.56%   +0.35%     
==========================================
  Files          16       16              
  Lines        2715     2760      +45     
  Branches      765      766       +1     
==========================================
+ Hits         1879     1920      +41     
- Misses        450      453       +3     
- Partials      386      387       +1     
Impacted Files Coverage Δ
...lc_parameter/src/rclc_parameter/parameter_server.c 83.10% <95.55%> (+0.68%) ⬆️

... and 1 file with indirect coverage changes

@JanStaschulat
Copy link
Contributor

JanStaschulat commented Jun 14, 2023

@pablogs9 @Acuadros95
the ci pipeline on OSRF build farm is not triggered for Rolling and Iron for all of the pending pull requests. Do you have any idea what else to check?

created an issue for this: #366

@JanStaschulat JanStaschulat merged commit f6d86b4 into iron Jun 14, 2023
@JanStaschulat JanStaschulat deleted the mergify/bp/iron/pr-354 branch June 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants