Skip to content

updated rclc_examples #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanStaschulat merged 1 commit into from
Feb 7, 2023
Merged

updated rclc_examples #332

JanStaschulat merged 1 commit into from
Feb 7, 2023

Conversation

@JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Feb 7, 2023 •
edited
Loading

  • renamed example_executor_convenience.c to example_executor.c (this should be the typical use case)
  • renamed example_executor.c to example_executor_only_rcl.c (depricated, was only used to show that the executor can be used with RCL API alone.
  • changed rclc_executor_spin_some with for-loop to rclc_executor_spin() (this should be the typical use case)
  • updated README
  • added a note about the XRCE-DDS middleware configuration of number of publishers/subscribers etc.
  • corrected link for example_short_timer_long_callback demo

@JanStaschulat
updated documentation
0e934dc 
Signed-off-by: Jan Staschulat <[email protected]>
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented Feb 7, 2023

@mergify backport foxy humble

@mergify
Copy link
Contributor

mergify bot commented Feb 7, 2023 •
edited
Loading

backport foxy humble

✅ Backports have been created

Details

@JanStaschulat JanStaschulat merged commit e63b644 into master Feb 7, 2023
@JanStaschulat JanStaschulat deleted the feature/update-documentation-rclc-examples branch February 7, 2023 17:09
@mergify mergify bot mentioned this pull request Feb 7, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 7, 2023
@JanStaschulat @mergify
updated documentation (#332)
bf3e517 
Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit e63b644)

# Conflicts:
#	rclc_examples/README.md
mergify bot pushed a commit that referenced this pull request Feb 7, 2023
@JanStaschulat @mergify
updated documentation (#332)
b2d30d4 
Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit e63b644)
@mergify mergify bot mentioned this pull request Feb 7, 2023
Merged
JanStaschulat added a commit that referenced this pull request Feb 8, 2023
@mergify @JanStaschulat
updated documentation (#332) (#334)
6d83359 
Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit e63b644)

Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat added a commit that referenced this pull request Feb 8, 2023
@mergify @JanStaschulat
updated rclc_examples (backport #332) (#333)
23c65ba 
* updated documentation (#332)

Signed-off-by: Jan Staschulat <[email protected]>
(cherry picked from commit e63b644)

# Conflicts:
#	rclc_examples/README.md

* resolved merge conflict

Signed-off-by: Jan Staschulat <[email protected]>

---------

Signed-off-by: Jan Staschulat <[email protected]>
Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanStaschulat @pablogs9