Drop build dependency on std_msgs #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]>
pablogs9
approved these changes
Jan 19, 2023
Member
pablogs9
left a comment
pablogs9
left a comment
There was a problem hiding this comment.
This LGTM, @JanStaschulat let us know if you find any problems.
Contributor
|
@mergify backport humble galactic foxy |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit b29efa9)
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit b29efa9)
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit b29efa9)
JanStaschulat
added a commit
that referenced
this pull request
Jan 23, 2023
* Drop build dependency on std_msgs (#314) This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit b29efa9) * trigger build job again Signed-off-by: Jan Staschulat <[email protected]> * trigger build job (2) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Jan Staschulat <[email protected]> Co-authored-by: Scott K Logan <[email protected]> Co-authored-by: Jan Staschulat <[email protected]>
JanStaschulat
added a commit
that referenced
this pull request
Jan 23, 2023
* Drop build dependency on std_msgs (#314) This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there. Signed-off-by: Scott K Logan <[email protected]> Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit b29efa9) * modify a line (typo) Signed-off-by: Jan Staschulat <[email protected]> * revert change - only to restart build process (github CI job) Signed-off-by: Jan Staschulat <[email protected]> Signed-off-by: Jan Staschulat <[email protected]> Co-authored-by: Scott K Logan <[email protected]> Co-authored-by: Jan Staschulat <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency is only needed when BUILD_TESTING is specified, and is already found via find_package() there.
Building packages with -DBUILD_TESTING=OFF should succeed in the absence of <test_depends> dependencies, which is why this issue came to my attention.
This change should be backported to Humble to avoid breaking the deb builds when we disable tests in the near future.