Skip to content

github action: updated os-version to ubuntu-22.04 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JanStaschulat merged 1 commit into from
May 30, 2022
Merged

github action: updated os-version to ubuntu-22.04 #295

JanStaschulat merged 1 commit into from
May 30, 2022

Conversation

@JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented May 30, 2022

No description provided.

@JanStaschulat
updated os-version to ubuntu-22.04
6aadc0a 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #295 (6aadc0a) into humble (5b87dca) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           humble     #295      +/-   ##
==========================================
+ Coverage   69.06%   69.13%   +0.07%     
==========================================
  Files          16       16              
  Lines        2715     2715              
  Branches      765      765              
==========================================
+ Hits         1875     1877       +2     
+ Misses        452      451       -1     
+ Partials      388      387       -1
Impacted Files Coverage Δ
rclc/src/rclc/action_goal_handle.c 59.87% <0.00%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0cd79b...6aadc0a. Read the comment docs.

@JanStaschulat JanStaschulat requested a review from pablogs9 May 30, 2022 11:00
@JanStaschulat JanStaschulat merged commit b944445 into humble May 30, 2022
@JanStaschulat JanStaschulat deleted the feature/update-os-to-ubuntu-22.04 branch May 30, 2022 12:38
@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 30, 2022

@mergify backport master

@mergify
Copy link
Contributor

mergify bot commented May 30, 2022

backport master

❌ No backport have been created

Details

The new Mergify permissions must be accepted to create pull request with .github/workflows changes.
You can accept them at https://dashboard.mergify.com/

@pablogs9
Copy link
Member

pablogs9 commented May 30, 2022

@JanStaschulat This mergify error should be fixed by ros2 organization owners, right?

@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 30, 2022 •
edited
Loading

@pablogs9 . Yes. I posted this error in the Mergify customer-chat: The response was to contact ros2 maintainers.
grafik

grafik

@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 30, 2022

@clalancette could you update these mergify permissions on ros2/rclc repo?

@clalancette
Copy link

clalancette commented May 31, 2022

@clalancette could you update these mergify permissions on ros2/rclc repo?

I've updated the permissions now. Give it a try again.

@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 31, 2022

@mergify backport master

mergify bot pushed a commit that referenced this pull request May 31, 2022
@JanStaschulat @mergify
updated os-version to ubuntu-22.04 (#295)
0d186ea 
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
(cherry picked from commit b944445)

# Conflicts:
#	.github/workflows/ci.yml
@mergify mergify bot mentioned this pull request May 31, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

backport master

✅ Backports have been created

Details

@JanStaschulat
Copy link
Contributor Author

JanStaschulat commented May 31, 2022

@clalancette could you update these mergify permissions on ros2/rclc repo?

I've updated the permissions now. Give it a try again.

Thanks a lot @clalancette, mergify works again. CC @pablogs9

JanStaschulat added a commit that referenced this pull request Jun 2, 2022
@mergify @JanStaschulat
github action: updated os-version to ubuntu-22.04 (backport #295) (#296)
71a8d2b 
* updated os-version to ubuntu-22.04 (#295)

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
(cherry picked from commit b944445)

# Conflicts:
#	.github/workflows/ci.yml

* resolved merge conflict

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>

Co-authored-by: Jan Staschulat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JanStaschulat @codecov-commenter @pablogs9 @clalancette