Skip to content

Remove references to rclrs not being on crates.io #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Mar 20, 2024

Fixes #334

@esteve esteve requested a review from a team March 20, 2024 11:50
Copy link
Collaborator

@maspe36 maspe36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be possible to build an rclrs node without having the entirety of ros2_rust in your workspace or an underlay?

@esteve
Copy link
Collaborator Author

esteve commented Mar 20, 2024

@maspe36 I'm afraid I'm a bit lost here, is your comment about #380 ?

@maspe36
Copy link
Collaborator

maspe36 commented Mar 20, 2024

I am specifically referring to this removed line

Note: Once rclrs is published on crates.io, it's not technically needed anymore to clone the ros2_rust repo, and this section will be modified to reflect that.

It sounds like once I run these commands,

cargo install --debug cargo-ament-build 
pip install git+https://github.com/colcon/colcon-cargo.git
pip install git+https://github.com/colcon/colcon-ros-cargo.git

I could write a node in rust that pulls rclrs from crates.io when I colcon build. Is that understanding correct?

@mxgrey
Copy link
Collaborator

mxgrey commented Mar 21, 2024

I'd love to be wrong about this but I think for now you'd at least need to have rosild_generator_rs in your colcon workspace with the message packages that you need. If we can get that package on the build farm then I think the usage you're describing would work.

@maspe36 maspe36 merged commit 996c091 into main Mar 21, 2024
@delete-merged-branch delete-merged-branch bot deleted the remove-crates-warning branch March 21, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix documentation now that rclrs is on crates.io
3 participants