-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Pass node options to costmap node #5202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass node options to costmap node #5202
Conversation
@MarcoMatteoBassa please fix the failing CI jobs (DCO and linting it looks like). Also, did you test this using a namespace? You can do so with |
I fixed the linting but I can't do DCO for you. You can ignore the precommit failure, that's on a github workflow file that I already fixed as part of the Kilted release process |
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Marco Bassa <[email protected]>
0ce6d0d
to
7c8222d
Compare
Signed-off-by: Marco Bassa <[email protected]>
Thanks! It would look like the namespace is correctly passed to the child nodes if added, yes Ex:
I passed the options to the global costmap from the planner server too for completeness. |
* Passing parent node options from controller_server to costmap node Signed-off-by: Marco Bassa <[email protected]> * Passing parent node options to global costmap Signed-off-by: Marco Bassa <[email protected]> --------- Signed-off-by: Marco Bassa <[email protected]>
Closes ros-navigation#5242 Inspired by: ros-navigation#5202 - `bt_navigator_***_rclcpp_node` now gets the same namespace of `bt_navigator` - `bt_navigator_***_rclcpp_node` now gets the same node options of `bt_navigator` (apart from node name, that is still forced to respect the pattern `bt_navigator_***_rclcpp_node` ) Signed-off-by: Patrick Roncagliolo <[email protected]>
…#5310) * `bt_navigator_***_rclcpp_node` - Namespacing + NodeOptions forwarding Closes #5242 Inspired by: #5202 - `bt_navigator_***_rclcpp_node` now gets the same namespace of `bt_navigator` - `bt_navigator_***_rclcpp_node` now gets the same node options of `bt_navigator` (apart from node name, that is still forced to respect the pattern `bt_navigator_***_rclcpp_node` ) Signed-off-by: Patrick Roncagliolo <[email protected]> * Deduplicate `replaceOrAddArgument` implementation Moved to `nav2_ros_common/node_utils.hpp`, namespace `nav2` Signed-off-by: Patrick Roncagliolo <[email protected]> --------- Signed-off-by: Patrick Roncagliolo <[email protected]>
…ros-navigation#5310) * `bt_navigator_***_rclcpp_node` - Namespacing + NodeOptions forwarding Closes ros-navigation#5242 Inspired by: ros-navigation#5202 - `bt_navigator_***_rclcpp_node` now gets the same namespace of `bt_navigator` - `bt_navigator_***_rclcpp_node` now gets the same node options of `bt_navigator` (apart from node name, that is still forced to respect the pattern `bt_navigator_***_rclcpp_node` ) Signed-off-by: Patrick Roncagliolo <[email protected]> * Deduplicate `replaceOrAddArgument` implementation Moved to `nav2_ros_common/node_utils.hpp`, namespace `nav2` Signed-off-by: Patrick Roncagliolo <[email protected]> --------- Signed-off-by: Patrick Roncagliolo <[email protected]>
Basic Info
Description of contribution in a few bullet points
Currently it is impossible to remap the publishers and subscribers of the costmap objects, because the node options of the controller server are not passed to the child node.
The change allows the child costmap node to inherit the node options of the parent, while still using customized options for the name, namespace and use_sim_time.
Description of how this change was tested
Future work that may be required in bullet points
The free functions might be moved to utils and used where other child nodes are created if the use-case arises.
For Maintainers: