Possibly add additional configuration options for Loopback Simulator

[filip-k-aion]

Feature request

Add additional config options to Loopback Simulator

Feature description

I have been getting good use out of the loopback simulator, and testing things above the controller in a light weight environment. However, I was wondering if we could add more configuration options of the produced scan topic to allow for different fov, ranges, or for producing inf when there is nothing within range.

Implementation considerations

Based off of a quick look at the code, it looks like should be as simple as replacing the constants in this function with ros params. Just want to know if this is something that other people would find useful?

[SteveMacenski]

Sure thing! Sounds like a nice feature addition!

[SteveMacenski]

@filip-k-aion is this something you're working on or planning to contribute? 😄

[filip-k-aion]

Yeah, we have it as an item to do at my job, and wanted to see if there was interest. So my plan was to create a PR once I have had the time to get it done and prove it out at work.

[SteveMacenski]

Great, thanks! Do you have a sense of when we should expect it? 🙂

[filip-k-aion]

If nothing else comes up, I think I should be able to get to it in the next few weeks.

[RamanaBotta]

Hi @SteveMacenski and @filip-k-aion
I would like work on this issue. Let me know what are the things to to be added or to be improved.

[SteveMacenski]

@filip-k-aion can you give an update?

@RamanaBotta please see the original ticket’s description! Do you have any specific questions we can help answer?

[RamanaBotta]

Hi @SteveMacenski ,
Ihave gone through the this ticket's description,Its clear. Mostly its about sensor fov and ranges.

[filip-k-aion]

@RamanaBotta I have not gotten time to work on it. If you would like work on it, go for it!

[RamanaBotta]

@filip-k-aion , Sure. I will work on it.

[SteveMacenski]

@RamanaBotta any update? :-)

[RamanRobotics]

@SteveMacenski Yes, I have just raised a pull request on it.
@filip-k-aion, Consider reviewing it and let me know if anythings to be added.

[filip-k-aion]

@RamanRobotics Took a quick look at it here. It looks good from my standpoint, just saw two small tweaks that it needs, along with documentation updates in the README.md.
Thanks for doing this!